Add RISC-V Vector Extension implementation of from_chars - #196
Open
e4d08 wants to merge 2 commits into
Open
Conversation
The BOOST_UUID_USE_RISCV_V config macro is automatically defined when the compiler defines __riscv_v, indicating RISC-V Vector Extension (V 1.0+) support is available. The macro is also added to the BOOST_UUID_NO_SIMD exclusion list.
This adds a RISC-V Vector (RVV) implementation of the from_chars algorithm, ported from the x86 SIMD implementation. The RVV version supports VLEN >= 128 and handles narrow and wide character types (char, char16_t, char32_t). The implementation follows the same structure as from_chars_x86.hpp: deinterleaving of input character pairs, dash validation, hex character validation, and nibble packing. It uses two separate expected dash vectors (one per character pair) instead of x86's single shuffled vector, as RVV's vrgather-based deinterleaving makes this approach more natural. The generic fallback path is preserved: both the x86 and RISC-V SIMD paths dispatch to from_chars_generic when std::is_constant_evaluated() is true.
Member
|
That's interesting but we need a way to test it. |
Author
|
I could add RISC-V tests to the CI, but I need your opinion on the best way of doing it. I consider cross-compiling and running tests under QEMU, but maybe there are better options. If cross-compiling is eligible, let me know and I will implement it. |
Member
|
I don't know of a better way, so we could try that. But please use a separate PR for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a RISC-V Vector (RVV) implementation of the
from_charsalgorithm, ported from the x86 SIMD implementation. The implementation supports VLEN >= 128 and handles narrow and wide character types (char,char16_t,char32_t).This PR is heavily inspired by Andrey Semashev's work on x86 SIMD implementations.
The performance effect on Spacemit-X60 (riscv64), gcc 16.1.0, in millions of successful
from_chars()calls per second:The unsuccessful parsing case depends on where the error happens, as the generic version may terminate sooner if the error is detected at the beginning of the input string, while the SIMD version performs roughly the same amount of work but faster. Here are some examples for 8-bit character types (for larger types the numbers are more or less comparable):
Early errors (EOI at 1 char, illegal char at 0) are significantly slower with RVV — the 1-character input cannot amortize the SIMD setup cost, resulting in a ~13x slowdown. This is consistent with the x86 implementation's behavior, which shows the same pattern.
The missing dash at position 8 case shows a slight regression (0.67x), unlike x86 which achieves a speedup for this scenario. This is likely because the RVV implementation uses two separate expected dash vectors — one per deinterleaved character pair — rather than x86's single shuffled vector. The early error at position 8 does not recoup the overhead of this approach.
Late errors and successful parses all show worthwhile speedups ranging from 1.71x to 2.73x. In general, for inputs where the SIMD path can reach its full processing width, the RVV implementation provides a consistent ~2x improvement over the generic path across all character types.
The test code that was used for benchmarking is the same as the one in PR #186 (with running the successful parse twice for warmup):
uuid_from_chars_perftest.cpp
Compile and run with: